-
Notifications
You must be signed in to change notification settings - Fork 693
Hide trace scheduler from spring sleuth #2158
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
============================================
+ Coverage 72.77% 72.79% +0.02%
- Complexity 1931 1933 +2
============================================
Files 245 245
Lines 7077 7083 +6
Branches 733 733
============================================
+ Hits 5150 5156 +6
Misses 1587 1587
Partials 340 340
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the trace integration tests; everything seems to be in order.
Thank you!
@Bean | ||
@ConditionalOnMissingBean(name = "traceExecutorProvider") | ||
public ExecutorProvider traceExecutorProvider(@Qualifier("traceSenderThreadPool") ThreadPoolTaskScheduler scheduler) { | ||
public ExecutorProvider traceExecutorProvider(GcpTraceProperties traceProperties, @Qualifier("traceSenderThreadPool") Optional<ThreadPoolTaskScheduler> userProvidedScheduler) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Optional
works here? I thought we have to use ObjectProvider
.
cc/ @artembilan
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's OK to stick with Optional
for simple use-cases.
Co-authored-by: JBodkin <[email protected]>
Fixes #2148, #2016.