This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
Hide trace scheduler from spring sleuth #2158
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2158 +/- ##
============================================
+ Coverage 72.77% 72.79% +0.02%
- Complexity 1931 1933 +2
============================================
Files 245 245
Lines 7077 7083 +6
Branches 733 733
============================================
+ Hits 5150 5156 +6
Misses 1587 1587
Partials 340 340
Continue to review full report at Codecov.
|
elefeint
approved these changes
Jan 31, 2020
meltsufin
approved these changes
Jan 31, 2020
| @Bean | ||
| @ConditionalOnMissingBean(name = "traceExecutorProvider") | ||
| public ExecutorProvider traceExecutorProvider(@Qualifier("traceSenderThreadPool") ThreadPoolTaskScheduler scheduler) { | ||
| public ExecutorProvider traceExecutorProvider(GcpTraceProperties traceProperties, @Qualifier("traceSenderThreadPool") Optional<ThreadPoolTaskScheduler> userProvidedScheduler) { |
There was a problem hiding this comment.
Optional works here? I thought we have to use ObjectProvider.
cc/ @artembilan
There was a problem hiding this comment.
I think it's OK to stick with Optional for simple use-cases.
elefeint
pushed a commit
that referenced
this pull request
Jan 31, 2020
elefeint
added a commit
that referenced
this pull request
Feb 3, 2020
Co-authored-by: JBodkin <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2148, #2016.