Skip to content
This repository has been archived by the owner on Jan 19, 2022. It is now read-only.

Disabling auto-configuration of instrumenting executor beans reduces visibility #2148

Closed
JBodkin-LH opened this issue Jan 29, 2020 · 1 comment · Fixed by #2158
Closed

Disabling auto-configuration of instrumenting executor beans reduces visibility #2148

JBodkin-LH opened this issue Jan 29, 2020 · 1 comment · Fixed by #2158
Labels

Comments

@JBodkin-LH
Copy link

Describe the bug
The documentation for 1.2.1 recommends to disable spring.sleuth.scheduled.enabled=false to prevent many traces appearing with the name async. This is problematic for applications that use executors under the hood, which can be commonly used in reactive programming when running IO requests or running asynchronous code.

The workaround to exclude the thread pool bean created by this project would be a better recommendation rather than disabling the setting. Ideally as mentioned in the original issue, it would be best to automatically exclude the code in this project from being traced.

Reference: #1978

Sample

@elefeint
Copy link
Contributor

I opened #2016 a couple of months back to completely hide the internal scheduler pool from the spring context.
This might be a good first issue, actually, since #2013 provides an example of hiding a scheduler in another one of our autoconfigurations.

Would you be interested in contributing the code?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging a pull request may close this issue.

3 participants