This repository has been archived by the owner on Jan 19, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 693
Trace Sample generates extra traces #1978
Comments
@adriancole FYI |
One workaround is to exclude the
|
Ultimately we need to make sure that all of our thread pool beans are not instrumented by Sleuth. |
codefromthecrypt
pushed a commit
to spring-cloud/spring-cloud-sleuth
that referenced
this issue
Oct 10, 2019
Recently, `AsyncAutoConfiguration` auto-instruments executors. This causes spans named 'async' with no tag or other metadata to help understand what is happening. It was somewhat difficult troubleshooting this because the control is by bean name, but for example the "async" span doesn't include the bean name. For starters, this allows people to opt-out of automatically spanning executors via `spring.sleuth.async.enabled=false` See spring-attic/spring-cloud-gcp#1978 cc @meltsufin @saturnism
codefromthecrypt
pushed a commit
to spring-cloud/spring-cloud-sleuth
that referenced
this issue
Oct 23, 2019
Recently, `AsyncAutoConfiguration` auto-instruments executors. This causes spans named 'async' with no tag or other metadata to help understand what is happening. It was somewhat difficult troubleshooting this because the control is by bean name, but for example the "async" span doesn't include the bean name. For starters, this allows people to opt-out of automatically spanning executors via `spring.sleuth.async.enabled=false` See spring-attic/spring-cloud-gcp#1978 cc @meltsufin @saturnism
marcingrzejszczak
pushed a commit
to spring-cloud/spring-cloud-sleuth
that referenced
this issue
Oct 23, 2019
* Adds the possibility to opt-out of executor decoration Recently, `AsyncAutoConfiguration` auto-instruments executors. This causes spans named 'async' with no tag or other metadata to help understand what is happening. It was somewhat difficult troubleshooting this because the control is by bean name, but for example the "async" span doesn't include the bean name. See spring-attic/spring-cloud-gcp#1978
We need to add |
meltsufin
added a commit
that referenced
this issue
Nov 4, 2019
Also document the use of `spring.sleuth.scheduled.enabled=false`, which is used to disable automatic instrumentation of executors by Sleuth. Fixes: #1978.
meltsufin
added a commit
that referenced
this issue
Nov 5, 2019
Also document the use of `spring.sleuth.scheduled.enabled=false`, which is used to disable automatic instrumentation of executors by Sleuth. Fixes: #1978.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
When running the sample, we expect to just see one trace per user request, but instead we see many addition traces called
async
that seem to have nothing to do with the request.The text was updated successfully, but these errors were encountered: