Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with missing dot in property name #494

Closed
wants to merge 1 commit into from
Closed

Fix issue with missing dot in property name #494

wants to merge 1 commit into from

Conversation

corneil
Copy link
Contributor

@corneil corneil commented Nov 12, 2024

Updated environmentVariables usage to include a dot.

Fixes #492

@corneil
Fix issue with missing dot in property name
7f28f93 
Updated environmentVariables usage to include a dot.

Fixes spring-cloud#492
@corneil corneil requested review from cppwfs and onobc November 12, 2024 13:01
@corneil corneil added the type/bug Is a bug report label Nov 12, 2024
corneil added a commit that referenced this pull request Nov 12, 2024
@corneil
Revert change committed directly
c7bccf3 
Reverts change for PR #494
@corneil corneil added the type/backport Is a issue to track backport, use with branch/xxx label Nov 12, 2024
@cppwfs
Copy link
Contributor

cppwfs commented Nov 12, 2024

Due to the commit number being resused for this PR it was not a clean merge. So created a new commit 241f872 to push the update.

@corneil Thanks for the PR!

@cppwfs cppwfs closed this Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cppwfs cppwfs Awaiting requested review from cppwfs

@onobc onobc Awaiting requested review from onobc

Assignees
No one assigned
Labels
review/at-least-one type/backport Is a issue to track backport, use with branch/xxx type/bug Is a bug report
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@corneil @cppwfs