Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MIssing dot when get getDeploymentPropertyValue #492

Closed
ddkkinf opened this issue Nov 12, 2024 · 0 comments · Fixed by #493
Closed

MIssing dot when get getDeploymentPropertyValue #492

ddkkinf opened this issue Nov 12, 2024 · 0 comments · Fixed by #493
Assignees
Labels

Comments

@ddkkinf
Copy link

ddkkinf commented Nov 12, 2024

We tried to use init container with environment variable
deployer.<application>.kubernetes.init-container.environment-variables=env1=value1,env2=value2
But it does not applied.

Finally it works with
deployer.<application>.kubernetes.init-containerenvironment-variables=env1=value1,env2=value2

I think there is a typo

String envString = PropertyParserUtils.getDeploymentPropertyValue(kubeProps, propertyKey + "environmentVariables");

We use Version: 2.11.5

@github-actions github-actions bot added the status/need-triage Team needs to triage and take a first look label Nov 12, 2024
corneil added a commit that referenced this issue Nov 12, 2024
Updated environmentVariables usage to include a dot.

Fixes #492
corneil added a commit to corneil/spring-cloud-deployer that referenced this issue Nov 12, 2024
Updated environmentVariables usage to include a dot.

Fixes spring-cloud#492
@corneil corneil added type/bug Is a bug report area/kubernetes and removed status/need-triage Team needs to triage and take a first look labels Nov 12, 2024
@cppwfs cppwfs closed this as completed in 3ce51f2 Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants