Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade poddisruptionbudget apiversion to v1 #405

Merged
merged 1 commit into from
Aug 24, 2022
Merged

upgrade poddisruptionbudget apiversion to v1 #405

merged 1 commit into from
Aug 24, 2022

Conversation

j18e
Copy link
Contributor

@j18e j18e commented May 9, 2022

Fixes apiversion for poddisruptionbudgets

Changes proposed on the PR:

  • stop using policy/v1beta1 api for poddisruptionbudgets
  • use instead policy/v1

@j18e j18e requested a review from ese as a code owner May 9, 2022 12:50
cndoit18
cndoit18 approved these changes Jun 27, 2022
View reviewed changes
Copy link
Collaborator

@cndoit18 cndoit18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@j18e
Copy link
Contributor Author

j18e commented Jun 27, 2022

@ese can i get a review from you? Would love to get this merged in

@samof76
Copy link
Contributor

samof76 commented Aug 4, 2022

Anyone merging this?

@samof76
Copy link
Contributor

samof76 commented Aug 18, 2022

@ese You merging this?

@ese ese merged commit 40d155f into spotahome:master Aug 24, 2022
@samof76 samof76 mentioned this pull request Sep 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cndoit18 cndoit18 cndoit18 approved these changes

@ese ese ese approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@j18e @samof76 @ese @cndoit18