Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated v1beta1.PodDisruptionBudget to v1.PodDisruptionBudget #467

Closed
szelenka opened this issue Sep 6, 2022 · 4 comments
Closed

Comments

@szelenka
Copy link

szelenka commented Sep 6, 2022

Expected behaviour

Add PodDisruptionBudget in k8s past version 1.25

Actual behaviour

Operator code explicitly references v1beta1.PodDisruptionBudget which is deprecated. This should be updated to v1.PodDistributionBudget
https://pkg.go.dev/k8s.io/[email protected]/policy/v1#PodDisruptionBudget

Steps to reproduce the behaviour

Install operator on k8s 1.21+ and create a Redis cluster through the Operator, view the Operator logs

Environment

How are the pieces configured?

  • Redis Operator version - v1.1.1
  • Kubernetes version - 1.21
  • Kubernetes configuration used (eg: Is RBAC active?) - yes

Logs

{
  "jsonPayload": {
    "message": "policy/v1beta1 PodDisruptionBudget is deprecated in v1.21+, unavailable in v1.25+; use policy/v1 PodDisruptionBudget",
    "pid": "8"
  },
  "sourceLocation": {
    "file": "warnings.go",
    "line": "70"
  }
}
@szelenka
Copy link
Author

szelenka commented Sep 6, 2022

working on a PR this week

@samof76
Copy link
Contributor

samof76 commented Sep 7, 2022

@szelenka how about this? #405

@szelenka
Copy link
Author

szelenka commented Sep 7, 2022

my mistake, what's the expected release date for v1.2.0?

@ese
Copy link
Member

ese commented Sep 7, 2022

We will release this week

@szelenka szelenka closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants