Implement Validity for SparseArray, make scalar_at for bitpacked array respect patches #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Need to make flatten respect the supplied fill type still |
gatesn
requested changes
Apr 4, 2024
jdcasale
force-pushed
the
jc/fix_scalar_at
branch
from
ab75bec
to
0095d79
Compare
jdcasale
force-pushed
the
jc/fix_scalar_at
branch
from
0095d79
to
4a2bebf
Compare
gatesn
previously requested changes
Apr 4, 2024
robert3005
reviewed
Apr 4, 2024
Comment on lines
38
to
41
| assert!( | ||
| all_fill_types_are_equal, | ||
| "Cannot concatenate SparseArrays with differing fill values" | ||
| ); |
There was a problem hiding this comment.
This should be an error not a panic, i.e. wrap it in an if statement and do vortex_bail!
robert3005
reviewed
Apr 4, 2024
robert3005
reviewed
Apr 4, 2024
Co-authored-by: Robert Kruszewski <[email protected]>
robert3005
approved these changes
Apr 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before:
Issue: #193
#147 uncovered that we did not respect patches in scalar_at calculations, causing a panic when REE ends arrays were bitpacked with patches.
After: