Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BitPacked::scalar_at to respect patches #193

Closed
gatesn opened this issue Apr 4, 2024 · 1 comment
Closed

BitPacked::scalar_at to respect patches #193

gatesn opened this issue Apr 4, 2024 · 1 comment
Assignees
@jdcasale

Comments

@gatesn
Copy link
Contributor

gatesn commented Apr 4, 2024

FLUP from #160
@robert3005 robert3005 mentioned this issue Apr 4, 2024
Merged
@jdcasale jdcasale mentioned this issue Apr 4, 2024
Merged
@lwwmanning lwwmanning mentioned this issue Apr 4, 2024
Closed
@lwwmanning lwwmanning assigned jdcasale and unassigned lwwmanning Apr 4, 2024
jdcasale added a commit that referenced this issue Apr 4, 2024
@jdcasale @lwwmanning @robert3005
Implement Validity for SparseArray, make scalar_at for bitpacked arra…
02d8180 
…y respect patches (#194)

before:
Issue: #193

#147 uncovered that we did not
respect patches in scalar_at calculations, causing a panic when REE ends
arrays were bitpacked with patches.


After:
* We have a validity is implementation for BitPackedArray
* ScalarAtFn for BitPackedArray no longer ignores patches
* benches/compress no longer panics
* flatten respects fill_value

---------

Co-authored-by: Will Manning <[email protected]>
Co-authored-by: Robert Kruszewski <[email protected]>
@robert3005
Copy link
Member

Fixed in #194

@robert3005 robert3005 mentioned this issue Apr 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jdcasale jdcasale

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

bitpacked scalar_at patches spiraldb/vortex
4 participants
@robert3005 @lwwmanning @gatesn @jdcasale