fix(artifacts): don't output buildArtifacts as korkArtifacts #3417
Conversation
| if (artifacts == null) { | ||
| artifacts = new ArrayList<>(); | ||
| } | ||
| artifacts.addAll(stageDefinition.getBuildInfo().getArtifacts()); |
There was a problem hiding this comment.
@jervi This essentially reverts a small part of your recent PR, #3408. It appears to have triggered a latent regression in PackageInfo.findTargetPackage() that only surfaces when CreateBakeTask is passed a fully qualified package name with suffix (i.e. "orca-1.2358.0-h333.bb7d1a2-x86_64.deb" instead of just "orca"). This is a pattern in use by a few teams at Netflix, hence the revert here. I haven't succeeded at unwinding the behavior in findTargetPacakge that this impacts.
There was a problem hiding this comment.
Hmm, I'll try to figure out a fix that let's us keep this without breaking your workflows. I'll assign the PR to you once it is ready :)
There was a problem hiding this comment.
I guess you haven't enabled the artifact decorator in your Spinnaker installation? Because the deb decorator in Igor should have renamed that package to orca if it came from Jenkins
…pinnaker#3417)" This reverts commit df36cfe.
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
…pinnaker#3417)" This reverts commit df36cfe.
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
…pinnaker#3417)" This reverts commit df36cfe.
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
…#3422) * Revert "fix(artifacts): don't output buildArtifacts as korkArtifacts (#3417)" This reverts commit df36cfe. * fix(artifacts): Revert #3417, but only add decorated artifacts Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one) * Add test for checking decorated flag * Simplify the code a tiny bit * Trigger new build * Trigger new build * Trigger new build Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
No description provided.