feat(core): Allow multiple custom decorators of the same type #582
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Wait a minute before merging this. I found a little thing I want to fix. I’ll push it soon. |
|
Fixed in 85a4ca1 |
|
We've run Igor with this PR merged internally in Schibsted for 9 days now. @gardleopard or maybe @ajordens can you please merge it? 🙏 |
jervi
commented
Jan 27, 2020
| @@ -45,4 +47,5 @@ public GenericArtifact(String type, String name, String version, String referenc | |||
| private String type; | |||
| private String version; | |||
| private Map<String, String> metadata; | |||
| private boolean decorated; | |||
There was a problem hiding this comment.
This will serialize this field as well and surface it to the pipeline execution. I had originally annotated it with @JsonIgnore but I removed it again because I felt it wouldn't hurt to actually expose the field. I'm happy to re-add it if someone feels different.
There was a problem hiding this comment.
Actually, I found a use for the flag (in spinnaker/orca#3422), so now I'm not so happy to ignore it anymore 😎
Each matched decorator will add another artifact to the build. This allows us to for instance migrate to new artifact types without breaking backwards compatibility. Example: We have historically used the type `docker` for docker images, but newer versions of Spinnaker expects Docker images to be of the type `docker/image`. Now we can define both decorators at the same time.
…doubled the number of artifacts in the output. Added test and a new check.
jervi
force-pushed
the
allow_multiple_custom_decorators
branch
from
ce81307
to
01f21d3
Compare
xavileon
approved these changes
Feb 5, 2020
|
@spinnaker/oss-reviewers PTAL |
|
I think @spinnaker/oss-approvers are the ones with rights to merge? |
jervi
added a commit
to jervi/orca
that referenced
this pull request
Feb 10, 2020
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
robzienert
approved these changes
Feb 10, 2020
jervi
added a commit
to jervi/orca
that referenced
this pull request
Feb 3, 2021
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
jervi
added a commit
to jervi/orca
that referenced
this pull request
Mar 15, 2021
Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one)
mergify bot
added a commit
to spinnaker/orca
that referenced
this pull request
Feb 4, 2022
…#3422) * Revert "fix(artifacts): don't output buildArtifacts as korkArtifacts (#3417)" This reverts commit df36cfe. * fix(artifacts): Revert #3417, but only add decorated artifacts Will only add artifacts that have been decorated in Igor (depends on the pending PR spinnaker/igor#582; but it is safe to merge this PR independent of that one) * Add test for checking decorated flag * Simplify the code a tiny bit * Trigger new build * Trigger new build * Trigger new build Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each matched decorator will add another artifact to the build. This allows us to for instance migrate to new artifact types without breaking backwards compatibility. Example: We have historically used the type
dockerfor docker images, but newer versions of Spinnaker expects Docker images to be of the typedocker/image. Now we can define both decorators at the same time.