refactor(*): Pull jenkins out into separate module; create new core abstractions #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emjburns
reviewed
Jan 22, 2020
| .duration(duration.intValue()) | ||
| // TODO(rz): Groovyism. What does Groovy do when `result` is null and you cast it to an | ||
| // enum? WHO KNOWS, but | ||
| // all of the igor tests depend on _something_ being set from null. |
|
Is there any chance this PR will be merged into master? |
|
Yes, it'll get merged into master, but I first need to finish it. You could consider this work "20% time", except that the 20% time comes out of my evenings / nights, so I can't give you an estimate of when I'll have it done. |
robzienert
force-pushed
the
jenkins-refactor
branch
2 times, most recently
from
5a83647
to
36c14fd
Compare
emjburns
reviewed
Jan 31, 2020
| @@ -0,0 +1,4 @@ | |||
| package com.netflix.spinnaker.igor.history.model; | |||
|
|
|||
| /** TODO(rz): Document. */ | |||
There was a problem hiding this comment.
Would probably be good to document these top level interfaces / how they will be used before some of the more specific things.
emjburns
reviewed
Feb 3, 2020
| } | ||
|
|
||
| // TODO(rz): lol, for real? |
robzienert
force-pushed
the
jenkins-refactor
branch
from
9742cec
to
e1dec7d
Compare
ttomsu
pushed a commit
to ttomsu/igor
that referenced
this pull request
Feb 24, 2020
…w core abstractions (spinnaker#594)" This reverts commit bb103cd.
ttomsu
pushed a commit
that referenced
this pull request
Feb 24, 2020
* Revert "fix(jenkins): Parse build number from Location header correctly (#627)" This reverts commit b6d10bb. * Revert "fix(jenkins): Fix build event details serialization (#626)" This reverts commit 5e7fbe2. * Revert "fix(docs): Fixing javadoc failures (#620)" This reverts commit 290abe8. * Revert "chore(build): Generate config props manifest (#618)" This reverts commit eb866bc. * Revert "refactor(*): Pull jenkins out into separate module; create new core abstractions (#594)" This reverts commit bb103cd.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I did this over the holiday break. It's a continuation of my desire to see Igor be a respectable service. Of all its warts, the biggest issue with it is that every CI provider needs to walk and talk as if it is Jenkins. It's understandable, as when it was originally written it was only for Jenkins.
This PR does a few things:
igor-monitor-jenkinsmodule.mainsource set to Java.I haven't had the chance to open this up again, but I wanted to put it out there for anyone that's particularly interested in reviewing large pull requests. I tried to keep the changeset as minimal as possible, because I don't think I can correctly make the right abstractions until all providers are decoupled from each other.
Side note: I see that IntelliJ "helpfully" rewrote a bunch of license headers. They will be fixed.