Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(codebuild): Add an API to list all AWS CodeBuild accounts #1023

Merged
merged 3 commits into from
Feb 4, 2020

Conversation

Kaixiang-AWS
Copy link
Contributor

@Kaixiang-AWS Kaixiang-AWS commented Jan 22, 2020

This API is used by deck to list all CodeBuild accounts configured in igor. As CodeBuild is different from other build services(Jenkins, Travis), it can't reuse the existing list accounts API.

Related Issue: spinnaker/spinnaker#5292

@clareliguori
Copy link
Member

Can you describe this more?

As CodeBuild is different from other build services(Jenkins, Travis), it can't reuse the existing list accounts API.

@Kaixiang-AWS
Copy link
Contributor Author

Igor is originally designed for Jenkins and assuming all other CI services are like Jenkins. Therefore it expects all CI services to fit into the framework it designs. For example, if I want to put codebuild into this framework, I have to implement a getBuild method which use build number as input. However, codebuild cannot retrieve a build by its build number. There are other places that codebuild cannot fit into this framework. Therefore, I implemented a similar, but much simpler solution for codebuild. This is exactly how GCB does because GCB also couldn't fit into that framework. There is someone working on refactoring igor to better abstract core concepts. spinnaker/igor#594 For now the only option is implementing codebuild's own logic outside of this framework.

@clareliguori
Copy link
Member

Approved, but merge is dependent on spinnaker/igor#595 getting merged in

@clareliguori clareliguori added ready to merge Approved and ready for merge and removed do not merge labels Feb 4, 2020
@mergify mergify bot merged commit 9487571 into spinnaker:master Feb 4, 2020
@mergify mergify bot added the auto merged label Feb 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants