fix(amazon): Clarify NLB healthcheck threshold requirements (#7890)

spinnaker · Feb 13, 2020 · 43c6d5d · 43c6d5d
1 parent 147f1a8
commit 43c6d5d
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/scripts/modules/amazon/src/help/amazon.help.ts b/app/scripts/modules/amazon/src/help/amazon.help.ts
@@ -114,6 +114,8 @@ const helpContents: { [key: string]: string } = {
   'aws.targetGroup.healthCheckProtocol': 'TCP health checks only support 10s and 30s intervals',
   'aws.targetGroup.healthCheckTimeout':
     'Target groups with TCP or TLS protocol must have a 6s timeout for HTTP health checks or a 10s timeout for HTTPS/TLS health checks.',
+  'aws.targetGroup.nlbHealthcheckThreshold':
+    'The healthy and unhealthy threshold for NLBs must be equal. This represents the number of successful and failed healthchecks required for healthy and unhealthy targets, respectively.',
   'aws.serverGroup.capacityConstraint': `
       <p>Ensures that the capacity of this server group has not changed in the background (i.e. due to autoscaling activity).</p>
       <p>If the capacity has changed, this resize operation will be rejected.</p>`,

diff --git a/app/scripts/modules/amazon/src/loadBalancer/configure/network/TargetGroups.tsx b/app/scripts/modules/amazon/src/loadBalancer/configure/network/TargetGroups.tsx
@@ -346,7 +346,10 @@ export class TargetGroups extends React.Component<ITargetGroupsProps, ITargetGro
                       </div>
                     </div>
                     <div className="wizard-pod-row">
-                      <div className="wizard-pod-row-title">Healthcheck Threshold</div>
+                      <div className="wizard-pod-row-title">
+                        <HelpField id="aws.targetGroup.nlbHealthcheckThreshold" />{' '}
+                        <span>Healthcheck Threshold&nbsp;</span>
+                      </div>
                       <div className="wizard-pod-row-contents">
                         <div className="wizard-pod-row-data">
                           <span className="wizard-pod-content">