Alternate format support for Timestamp casting (DATETIME for MySQL) #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
y-f-u
reviewed
Jul 21, 2024
y-f-u
approved these changes
Jul 21, 2024
sgrebnov
added a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR addresses Timestamp unparser issue producing invalid
CAST(col AS Timestamp)SQL for MySQL.MySQL cast function does not support Timestamp for CAST and requires DATETIME
Tested that DATETIME correctly handles timezone information. MySQL uses the local time zone for Timestamps, so the converted value from datetime_utc is correctly shown as the original value -7 (Seattle / GMT-7 local time zone). The same applies to datetime_utc_plus_4, as it is the original value in GMT+4 time zone, so it is converted to the local time zone as the original value -11 (difference between the local time zone and UTC+4).