Add support for IntervalStyle::MySQL #18
Merged
+222
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgrebnov
commented
Jul 18, 2024
y-f-u
reviewed
Jul 18, 2024
sgrebnov
commented
Jul 18, 2024
y-f-u
approved these changes
Jul 19, 2024
sgrebnov
added a commit
that referenced
this pull request
Jul 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
PR implements support for
IntervalStyle::MySQLThis fixes spiceai/spiceai#1950
MySQL Interval specification: https://dev.mysql.com/doc/refman/8.4/en/expressions.html#temporal-intervals
Note:
MySQL supports theDAY_MICROSECONDunit type (format isDAYS HOURS:MINUTES:SECONDS.MICROSECONDS), which can be used to optimize the number ofINTERVALelements for complex cases. The decision to use the current version (separateINTERVALs) is made to provide cleaner SQL for typical scenarios where only a fewINTERVALelements are used (day, hours, etc.).The implementation has been updated to generate single INTERVAL expression as generated intervals sequence can't be wrapped in brackets - (INTERVAL 1 YEAR + INTERVAL 1 MONTH ...) so we need single expression so it works correct for interval subtraction cases