-
-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't require the output dir to exist at startup, it might not exist yet #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There may be problems with these strict checks too? I didn't test these cases so haven't changed them. if sphinx_args.doctreedir:
args.doctree_dir = Path(sphinx_args.doctreedir).resolve(strict=True)
else:
args.doctree_dir = None
if sphinx_args.warnfile:
args.warnings_file = Path(sphinx_args.warnfile).resolve(strict=True)
else:
args.warnings_file = None |
Also happening with CPython docs: ❯ make -C Doc clean venv htmllive
rm -rf ./venv
rm -rf build/*
Creating venv in ./venv
Using Python 3.13.0rc2
Creating virtualenv at: ./venv
Activate with: source venv/bin/activate
Resolved 29 packages in 12ms
Installed 29 packages in 74ms
+ accessible-pygments==0.0.5
+ alabaster==1.0.0
+ babel==2.16.0
+ beautifulsoup4==4.12.3
+ blurb==1.2.1
+ certifi==2024.8.30
+ charset-normalizer==3.3.2
+ docutils==0.21.2
+ idna==3.10
+ imagesize==1.4.1
+ jinja2==3.1.4
+ markupsafe==2.1.5
+ packaging==24.1
+ pydata-sphinx-theme==0.15.4
+ pygments==2.18.0
+ requests==2.32.3
+ snowballstemmer==2.2.0
+ soupsieve==2.6
+ sphinx==8.0.2
+ sphinx-notfound-page==1.0.4
+ sphinxcontrib-applehelp==2.0.0
+ sphinxcontrib-devhelp==2.0.0
+ sphinxcontrib-htmlhelp==2.1.0
+ sphinxcontrib-jsmath==1.0.1
+ sphinxcontrib-qthelp==2.0.0
+ sphinxcontrib-serializinghtml==2.0.0
+ sphinxext-opengraph==0.9.1
+ typing-extensions==4.12.2
+ urllib3==2.2.3
The venv has been created in the ./venv directory
/Applications/Xcode.app/Contents/Developer/usr/bin/make _ensure-package PACKAGE=sphinx-autobuild
venv already exists.
To recreate it, remove it first with `make clean-venv'.
if uv --version >/dev/null 2>&1; then \
VIRTUAL_ENV=./venv uv pip install sphinx-autobuild; \
else \
./venv/bin/python3 -m pip install sphinx-autobuild; \
fi
Resolved 31 packages in 8ms
Installed 10 packages in 6ms
+ anyio==4.4.0
+ click==8.1.7
+ colorama==0.4.6
+ h11==0.14.0
+ sniffio==1.3.1
+ sphinx-autobuild==2024.9.3
+ starlette==0.38.5
+ uvicorn==0.30.6
+ watchfiles==0.24.0
+ websockets==13.0.1
mkdir -p build
Building NEWS from Misc/NEWS.d with blurb
./venv/bin/sphinx-autobuild -b html -d build/doctrees -j auto --re-ignore="/venv/" --open-browser --delay 0 -W . build/html
Traceback (most recent call last):
File "/Users/hugo/github/python/cpython/main/Doc/./venv/bin/sphinx-autobuild", line 8, in <module>
sys.exit(main())
~~~~^^
File "/Users/hugo/github/python/cpython/main/Doc/venv/lib/python3.13/site-packages/sphinx_autobuild/__main__.py", line 34, in main
args, build_args = _parse_args(list(argv))
~~~~~~~~~~~^^^^^^^^^^^^
File "/Users/hugo/github/python/cpython/main/Doc/venv/lib/python3.13/site-packages/sphinx_autobuild/__main__.py", line 101, in _parse_args
args.outdir = Path(sphinx_args.outputdir).resolve(strict=True)
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^
File "/Users/hugo/.local/share/uv/python/cpython-3.13.0rc2-macos-aarch64-none/lib/python3.13/pathlib/_local.py", line 670, in resolve
return self.with_segments(os.path.realpath(self, strict=strict))
~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^
File "<frozen posixpath>", line 439, in realpath
FileNotFoundError: [Errno 2] No such file or directory: '/Users/hugo/github/python/cpython/main/Doc/build/html'
make: *** [build] Error 1 |
SecondSkoll
reviewed
Sep 17, 2024
… yet Co-authored-by: Michael Park <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #177.
With sphinx-autobuild 2023.9.3 and the https://github.com/python/peps repo:
With 2024.4.16 it gets further, then another error and servers the page showing "Not Found":
But one thing at a time :)
git bisect points to 41a7d8c (no PR):
This looks like the relevant bit:
We're just starting up, so the output directory (
build
in my case) might not exist yet. So let's not be strict in resolving it.https://docs.python.org/3/library/pathlib.html#pathlib.Path.resolve