Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create required dirs #282

Closed
wants to merge 2 commits into from
Closed

Conversation

DanRoscigno
Copy link

Add prerequisites for make sp-run

When I run make run I get two errors, missing _build dir and missing .doctrees dir.

I have gotten into the habit of running make html first and then make run, but having the dirs as prereqs for make run seems more appropriate.

Add prerequisites for `make sp-run`

When I run `make run` I get two errors, missing _build dir and missing .doctrees dir.
Makefile.sp Outdated Show resolved Hide resolved
@SecondSkoll
Copy link
Collaborator

As per #276 this is an issue with an upstream package, sphinx-autobuild. It is recommended to just run make html before make run. Your solution would fail if the directories already exist. A better solution would be to pin to the 2024.04.16 release of sphinx-autobuild until the issue is fixed.

Additionally, there is currently a PR open in that project to fix the issue.

@DanRoscigno
Copy link
Author

As per #276 this is an issue with an upstream package, sphinx-autobuild. It is recommended to just run make html before make run. Your solution would fail if the directories already exist. A better solution would be to pin to the 2024.04.16 release of sphinx-autobuild until the issue is fixed.

Additionally, there is currently a PR open in that project to fix the issue.

The -p prevents an error if the dir already exists, just like on this line:

mkdir -p $(SPHINXDIR)/node_modules/ ; \

But, I will close it and use the workaround.

@DanRoscigno DanRoscigno deleted the patch-1 branch September 16, 2024 23:57
@SecondSkoll
Copy link
Collaborator

As per #276 this is an issue with an upstream package, sphinx-autobuild. It is recommended to just run make html before make run. Your solution would fail if the directories already exist. A better solution would be to pin to the 2024.04.16 release of sphinx-autobuild until the issue is fixed.
Additionally, there is currently a PR open in that project to fix the issue.

The -p prevents an error if the dir already exists, just like on this line:

mkdir -p $(SPHINXDIR)/node_modules/ ; \

But, I will close it and use the workaround.

Of course it does, sorry! I was not paying enough attention.
I'll try and move that upstream PR along as much as I can. :)

@DanRoscigno
Copy link
Author

As per #276 this is an issue with an upstream package, sphinx-autobuild. It is recommended to just run make html before make run. Your solution would fail if the directories already exist. A better solution would be to pin to the 2024.04.16 release of sphinx-autobuild until the issue is fixed.
Additionally, there is currently a PR open in that project to fix the issue.

The -p prevents an error if the dir already exists, just like on this line:

mkdir -p $(SPHINXDIR)/node_modules/ ; \

But, I will close it and use the workaround.

Of course it does, sorry! I was not paying enough attention. I'll try and move that upstream PR along as much as I can. :)

No worries, I had to look up the flag to make sure that it was portable across operating systems. I will use make html in the guide I am writing since it makes sense for new writers to understand the workflow.

@SecondSkoll
Copy link
Collaborator

That's a good idea. I saw your CODA issue and that will be really helpful. Just be aware there will be some significant changes to the starter pack soon, as we'll be moving to the use-canonical-sphinx-extension branch, which requires less configuration.

Though I think I'll pin everything and tag this main branch before we move to that version, so that there'll be a permanent version of this iteration of the starter pack here (and hopefully the autobuild issue will be resolved by then).

@DanRoscigno
Copy link
Author

Cheers, I like the workflow described in that branch. I will try that out now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants