Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support arbitrary source URLs, closes #87 #88

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

anarcat
Copy link

@anarcat anarcat commented Sep 5, 2016

No description provided.

@sphinx-doc sphinx-doc deleted a comment from anarcat Jul 19, 2017
@sphinx-doc sphinx-doc deleted a comment from anarcat Jul 19, 2017
@bitprophet bitprophet added this to the 0.7.11 milestone Jul 19, 2017
@anarcat
Copy link
Author

anarcat commented Nov 16, 2017

... ping?

This allows the user to specify a different repository, possibly
outside of GitHub to link the "show source" to.

Closes: sphinx-doc#87
@anarcat
Copy link
Author

anarcat commented Nov 16, 2017

added docs and changelog entries for this - anything missing?

@bitprophet bitprophet modified the milestones: 0.7.11, 0.7.12 Sep 6, 2018
@bitprophet bitprophet modified the milestones: 0.7.12, 0.7.13 Dec 18, 2018
@abitrolly
Copy link

Needs to be rebased.

@anarcat
Copy link
Author

anarcat commented Jan 8, 2019

Needs to be rebased.

What are the odds of this being merged if I go through that effort? That PR has been idle for two years without feedback so I'm hesitant in working anymore on it.

@abitrolly
Copy link

I think odds are low. Thanking @bitprophet and asking how things are on the other side of the world might help to understand if he has time for the review. Otherwise it is just a good git practice.

image

You may be interested to know how to add arbitrary source URLs without patching this theme.

fedora-infra/anitya@84c7812#diff-cac3dc3bfd42bc240bc9eb924f8dbfdd

@abitrolly
Copy link

Made it into separate snippet and preserved your parameter name https://gist.github.com/abitrolly/12522b399c92606d7b09e9342c3f788b

@anarcat
Copy link
Author

anarcat commented Jan 10, 2019

i resolved the merge conflict at least now...

@abitrolly
Copy link

abitrolly commented Jan 11, 2019 via email

@bitprophet bitprophet deleted the branch sphinx-doc:master January 13, 2023 00:42
@bitprophet bitprophet closed this Jan 13, 2023
@AA-Turner AA-Turner reopened this Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants