Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

arbitrary "edit source" link targets #87

Open
anarcat opened this issue Sep 5, 2016 · 5 comments
Open

arbitrary "edit source" link targets #87

anarcat opened this issue Sep 5, 2016 · 5 comments
Labels
enhancement
Milestone
0.7.14

Comments

@anarcat
Copy link

anarcat commented Sep 5, 2016 •
edited
Loading

as the RTD sphinx theme, this theme somewhat enforces people use Github.com for their source control, something that may not be adequate for people hosted elsewhere. there's, for example, #52 for bitbucket support, but soon you'll have requests for Gitlab, Atlassian and whatnot.

how about simply making this configurable? you simply need a host prefix and you're done. sphinx_rtd did this in readthedocs/sphinx_rtd_theme#182, for example.

thanks for considering this.
@anarcat
Copy link
Author

anarcat commented Sep 5, 2016

update: sphinx_rtd_theme supports this fine, if you run a good enough version. :)

anarcat added a commit to anarcat/alabaster that referenced this issue Sep 5, 2016
@anarcat
support arbitrary source URLs, closes sphinx-doc#87
ac9adc3
@bitprophet bitprophet added this to the 0.7.9 milestone Sep 7, 2016
@bitprophet
Copy link
Collaborator

bitprophet commented Sep 7, 2016 •
edited
Loading

Because GH doesn't do links in titles, still: #88 is the PR for this. Thanks! Will test it out & merge when I have time. I don't use this feature much myself which is why it's not an instant "I get it, " - need to quickly view the before/after.

@anarcat
Copy link
Author

anarcat commented Nov 18, 2016

ping?

@bitprophet bitprophet modified the milestones: 0.7.9, 0.7.10 Feb 28, 2017
anarcat added a commit to anarcat/alabaster that referenced this issue Nov 16, 2017
@anarcat
support arbitrary source URLs
2defd13 
This allows the user to specify a different repository, possibly
outside of GitHub to link the "show source" to.

Closes: sphinx-doc#87
@bitprophet bitprophet modified the milestones: 0.7.11, 0.7.12 Sep 6, 2018
@bitprophet bitprophet modified the milestones: 0.7.12, 0.7.13 Dec 18, 2018
@abitrolly
Copy link

Most voted feature - https://github.com/bitprophet/alabaster/issues?q=is%3Aissue+is%3Aopen+sort%3Areactions-%2B1-desc

@abitrolly
Copy link

Found a way to patch source links with standard template override with Sphinx/Jinja2.

fedora-infra/anitya@84c7812

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
0.7.14
Development

No branches or pull requests
3 participants
@bitprophet @anarcat @abitrolly