Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closures are kept for children instead of global #189

Merged
merged 7 commits into from
Dec 13, 2024

format

285d7b6
Select commit
Loading
Failed to load commit list.
Merged

Closures are kept for children instead of global #189

format
285d7b6
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Dec 12, 2024 in 1s

66.58% (+12.67%) compared to 722df50

View this Pull Request on Codecov

66.58% (+12.67%) compared to 722df50

Details

Codecov Report

Attention: Patch coverage is 90.32258% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.58%. Comparing base (722df50) to head (285d7b6).

Files with missing lines Patch % Lines
...ckle.Sdk/Serialisation/V2/Send/SerializeProcess.cs 86.84% 5 Missing ⚠️
...kle.Sdk.Dependencies/Serialization/ChannelSaver.cs 85.71% 1 Missing and 3 partials ⚠️
...eckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs 25.00% 3 Missing ⚠️
...k/Serialisation/V2/DummySendServerObjectManager.cs 0.00% 1 Missing ⚠️
...s/Speckle.Sdk.Serialization.Tests/DetachedTests.cs 0.00% 1 Missing ⚠️
...alization.Tests/DummyReceiveServerObjectManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##              dev     #189       +/-   ##
===========================================
+ Coverage   53.91%   66.58%   +12.67%     
===========================================
  Files         236      252       +16     
  Lines        9436    10154      +718     
  Branches     1065     1075       +10     
===========================================
+ Hits         5087     6761     +1674     
+ Misses       4097     3046     -1051     
- Partials      252      347       +95

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov