Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closures are kept for children instead of global #189

Merged
merged 7 commits into from
Dec 13, 2024
Merged

Conversation

adamhathcock
Copy link
Member

  • closures are kept only for parents
  • no more global collection
  • now can pool closures as well as lists for data chunks

Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 90.32258% with 15 lines in your changes missing coverage. Please review.

Project coverage is 66.58%. Comparing base (722df50) to head (285d7b6).
Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ckle.Sdk/Serialisation/V2/Send/SerializeProcess.cs 86.84% 5 Missing ⚠️
...kle.Sdk.Dependencies/Serialization/ChannelSaver.cs 85.71% 1 Missing and 3 partials ⚠️
...eckle.Sdk/Serialisation/V2/Receive/ObjectLoader.cs 25.00% 3 Missing ⚠️
...k/Serialisation/V2/DummySendServerObjectManager.cs 0.00% 1 Missing ⚠️
...s/Speckle.Sdk.Serialization.Tests/DetachedTests.cs 0.00% 1 Missing ⚠️
...alization.Tests/DummyReceiveServerObjectManager.cs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##              dev     #189       +/-   ##
===========================================
+ Coverage   53.91%   66.58%   +12.67%     
===========================================
  Files         236      252       +16     
  Lines        9436    10154      +718     
  Branches     1065     1075       +10     
===========================================
+ Hits         5087     6761     +1674     
+ Misses       4097     3046     -1051     
- Partials      252      347       +95     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@didimitrie didimitrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamhathcock said i'm getting murdered if i do not approve, so approving

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants