Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK is non static and logging/tracing controls are moved to the connectors #239

Merged
merged 18 commits into from
Sep 18, 2024

Merge branch 'dev' into adam/cxpla-51-make-sdk-setup-and-logging-use-…

e20403b
Select commit
Loading
Failed to load commit list.
Merged

SDK is non static and logging/tracing controls are moved to the connectors #239

Merge branch 'dev' into adam/cxpla-51-make-sdk-setup-and-logging-use-…
e20403b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 18, 2024 in 1s

7.38% (-0.14%) compared to 1dbb2b6

View this Pull Request on Codecov

7.38% (-0.14%) compared to 1dbb2b6

Details

Codecov Report

Attention: Patch coverage is 0% with 133 lines in your changes missing coverage. Please review.

Project coverage is 7.38%. Comparing base (1dbb2b6) to head (e20403b).

Files with missing lines Patch % Lines
...dk/Speckle.Connectors.Utils/AutofacRegistration.cs 0.00% 44 Missing ⚠️
Sdk/Speckle.Connectors.Utils/Connector.cs 0.00% 24 Missing ⚠️
...eckle.Connectors.Utils/ConnectorActivityFactory.cs 0.00% 19 Missing ⚠️
...le.Connectors.Utils/Operations/ReceiveOperation.cs 0.00% 14 Missing ⚠️
...le.Connectors.Utils/Operations/RootObjectSender.cs 0.00% 8 Missing ⚠️
...ckle.Connectors.Utils/Common/AssemblyExtensions.cs 0.00% 7 Missing ⚠️
...eckle.Connectors.Utils/Operations/SendOperation.cs 0.00% 7 Missing ⚠️
.../Speckle.Connectors.DUI/Bindings/AccountBinding.cs 0.00% 3 Missing ⚠️
...ckle.Connectors.Utils/Operations/AccountService.cs 0.00% 3 Missing ⚠️
Sdk/Speckle.Connectors.Utils/SpeckleLogProvider.cs 0.00% 3 Missing ⚠️
... and 1 more
Additional details and impacted files 
@@           Coverage Diff            @@
##             dev    #239      +/-   ##
========================================
- Coverage   7.51%   7.38%   -0.14%     
========================================
  Files        241     243       +2     
  Lines       4683    4767      +84     
  Branches     548     564      +16     
========================================
  Hits         352     352              
- Misses      4316    4400      +84     
  Partials      15      15

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov