Dispose Containers (except for Autocad) (#250)

specklesystems · Sep 18, 2024 · 1dbb2b6 · 1dbb2b6
1 parent b52d66c
commit 1dbb2b6
Show file tree

Hide file tree

Showing 5 changed files with 11 additions and 13 deletions.
diff --git a/Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/SpeckleModule.cs b/Connectors/ArcGIS/Speckle.Connectors.ArcGIS3/SpeckleModule.cs
@@ -60,6 +60,7 @@ protected override bool CanUnload()
     //TODO - add your business logic
     //return false to ~cancel~ Application close
     _disposableLogger?.Dispose();
+    Container.Dispose();
     return true;
   }
 }
diff --git a/Connectors/Revit/Speckle.Connectors.RevitShared/Plugin/RevitExternalApplication.cs b/Connectors/Revit/Speckle.Connectors.RevitShared/Plugin/RevitExternalApplication.cs
@@ -74,6 +74,7 @@ public Result OnShutdown(UIControlledApplication application)
       // need to look for commonality
       _revitPlugin?.Shutdown();
       _disposableLogger?.Dispose();
+      _container?.Dispose();
     }
     catch (Exception e) when (!e.IsFatal())
     {

diff --git a/Connectors/Rhino/Speckle.Connectors.RhinoShared/Plugin/Speckle.Connectors.RhinoPlugin.cs b/Connectors/Rhino/Speckle.Connectors.RhinoShared/Plugin/Speckle.Connectors.RhinoPlugin.cs
@@ -87,6 +87,7 @@ protected override void OnShutdown()
   {
     _rhinoPlugin?.Shutdown();
     _disposableLogger?.Dispose();
+    Container?.Dispose();
     base.OnShutdown();
   }
 }
diff --git a/DUI3/Speckle.Connectors.DUI.WebView/DUI3ControlWebView.xaml.cs b/DUI3/Speckle.Connectors.DUI.WebView/DUI3ControlWebView.xaml.cs
@@ -6,7 +6,7 @@
 
 namespace Speckle.Connectors.DUI.WebView;
 
-public sealed partial class DUI3ControlWebView : UserControl, IBrowserScriptExecutor
+public sealed partial class DUI3ControlWebView : UserControl, IBrowserScriptExecutor, IDisposable
 {
   private readonly IEnumerable<Lazy<IBinding>> _bindings;
 
@@ -58,4 +58,7 @@ private void SetupBinding(IBinding binding)
   }
 
   public void ShowDevTools() => Browser.CoreWebView2.OpenDevToolsWindow();
+
+  //https://github.com/MicrosoftEdge/WebView2Feedback/issues/2161
+  public void Dispose() => Browser.Dispatcher.Invoke(() => Browser.Dispose(), DispatcherPriority.Send);
 }
diff --git a/Sdk/Speckle.Autofac/DependencyInjection/SpeckleContainer.cs b/Sdk/Speckle.Autofac/DependencyInjection/SpeckleContainer.cs
@@ -2,18 +2,10 @@
 
 namespace Speckle.Autofac.DependencyInjection;
 
-public class SpeckleContainer
+public sealed class SpeckleContainer(IContainer container) : IDisposable
 {
-  private readonly IContainer _container;
-
-  public SpeckleContainer(IContainer container)
-  {
-    _container = container;
-  }
-
   public T Resolve<T>()
-    where T : class
-  {
-    return _container.Resolve<T>();
-  }
+    where T : class => container.Resolve<T>();
+
+  public void Dispose() => container.Dispose();
 }