-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: executable-less API #2187
Conversation
d4e2fc8
to
f8873e9
Compare
Tests partially fail, but now so what 🤪 (Done to reduce changes) |
@saschanaz, is it ok to close this? we can keep the branch in case we want to bring anything back from here. |
Looking back, I think the core issue that lead me to do this is that ReSpec runs as a big singleton and there is no easy way to initialize all the internal states. (The biblio dictionary for example.) Adding a way to initialize could vastly simplify this. Does adding initialization function interest you? @sidvishnoi |
That said, I don't think I have time to find any good thing here. Let's close this and perhaps think about the initialization I mentioned. |
@saschanaz something like #2981? |
That's about extending the initialization process, I mean the initialization after everything so that it can run again for another document. |
Oh wait, I guess it can be done in #2981 👀 |
Not sure what (short term?) benefits it can add over using puppeteer/respecDocWriter. Can make an attempt later though. If I understand correctly, something like baserunner.runAll, but callable from node? |
Ultimately yes. I guess #2981 can be a good step before that. (It would also make the existing code more readable that way 😉) |
Just an initial draft...
Closes #1469, closes #631