Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: executable-less API #2187

Closed
wants to merge 129 commits into from
Closed

feat: executable-less API #2187

wants to merge 129 commits into from

Conversation

saschanaz
Copy link
Collaborator

@saschanaz saschanaz commented Mar 23, 2019

Just an initial draft...

Closes #1469, closes #631

@saschanaz saschanaz added the Low priority Suggestions with no good driving force label Oct 28, 2019
@saschanaz
Copy link
Collaborator Author

Tests partially fail, but now so what 🤪 (Done to reduce changes)

@marcoscaceres
Copy link
Contributor

@saschanaz, is it ok to close this? we can keep the branch in case we want to bring anything back from here.

@saschanaz
Copy link
Collaborator Author

Looking back, I think the core issue that lead me to do this is that ReSpec runs as a big singleton and there is no easy way to initialize all the internal states. (The biblio dictionary for example.) Adding a way to initialize could vastly simplify this.

Does adding initialization function interest you? @sidvishnoi

@saschanaz
Copy link
Collaborator Author

saschanaz commented Feb 16, 2021

That said, I don't think I have time to find any good thing here. Let's close this and perhaps think about the initialization I mentioned.

@saschanaz saschanaz closed this Feb 16, 2021
@saschanaz saschanaz deleted the executable-less branch February 16, 2021 00:43
@sidvishnoi
Copy link
Member

@saschanaz something like #2981?

@saschanaz
Copy link
Collaborator Author

saschanaz commented Feb 16, 2021

That's about extending the initialization process, I mean the initialization after everything so that it can run again for another document.

@saschanaz
Copy link
Collaborator Author

Oh wait, I guess it can be done in #2981 👀

@sidvishnoi
Copy link
Member

sidvishnoi commented Feb 16, 2021

Not sure what (short term?) benefits it can add over using puppeteer/respecDocWriter. Can make an attempt later though.

If I understand correctly, something like baserunner.runAll, but callable from node?

@saschanaz
Copy link
Collaborator Author

saschanaz commented Feb 16, 2021

If I understand correctly, something like baserunner.runAll, but callable from node?

Ultimately yes. I guess #2981 can be a good step before that. (It would also make the existing code more readable that way 😉)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Low priority Suggestions with no good driving force
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Browser executable-less preprocessor Add code coverage support
3 participants