Fix renaming files with custom model #3707
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to fix file renaming when using a custom model with a primary key name other than 'id'.
We use a custom model that changes the primary key name from
id
tomedia_id
:We want to rename a file as described in the docs (Retrieving media):
When renaming file
src/MediaCollections/Filesystem.php
tries to find a media model using theid
attribute instead of the actual primary key. This PR fixes this bug by using->getKey()
in this specific place, which works in both cases.