Merge pull request #3707 from esadewater/patch-1

Fix renaming files with custom model

src/MediaCollections/Filesystem.php

@@ -302,7 +302,7 @@ protected function renameMediaFile(Media $media): void
 
     protected function renameConversionFiles(Media $media): void
     {
-        $mediaWithOldFileName = config('media-library.media_model')::find($media->id);
+        $mediaWithOldFileName = config('media-library.media_model')::find($media->getKey());
         $mediaWithOldFileName->file_name = $mediaWithOldFileName->getOriginal('file_name');
 
         $conversionDirectory = $this->getConversionDirectory($media);

tests/Feature/Media/RenameTest.php

@@ -1,5 +1,8 @@
 <?php
 
+use Spatie\MediaLibrary\MediaLibraryServiceProvider;
+use Spatie\MediaLibrary\Tests\TestSupport\TestModels\TestCustomMediaWithCustomKeyName;
+
 it('will rename the file if it is changed on the media object', function () {
     $testFile = $this->getTestFilesDirectory('test.jpg');
 
@@ -14,6 +17,26 @@
     $this->assertFileExists($this->getMediaDirectory($media->id.'/test-new-name.jpg'));
 });
 
+it('will rename the file with a custom model with custom key name', function () {
+    config()->set('media-library.media_model', TestCustomMediaWithCustomKeyName::class);
+
+    (new MediaLibraryServiceProvider(app()))->register()->boot();
+
+    $this->setUpDatabaseCustomKeyName();
+
+    $testFile = $this->getTestFilesDirectory('test.jpg');
+
+    $media = $this->testModel->addMedia($testFile)->toMediaCollection();
+
+    $this->assertFileExists($this->getMediaDirectory($media->getKey().'/test.jpg'));
+
+    $media->file_name = 'test-new-name.jpg';
+    $media->save();
+
+    $this->assertFileDoesNotExist($this->getMediaDirectory($media->getKey().'/test.jpg'));
+    $this->assertFileExists($this->getMediaDirectory($media->getKey().'/test-new-name.jpg'));
+});
+
 it('will rename conversions', function () {
     $testFile = $this->getTestFilesDirectory('test.jpg');
 

tests/TestCase.php

@@ -5,9 +5,11 @@
 use CreateTemporaryUploadsTable;
 use Dotgetenv\Dotgetenv;
 use Illuminate\Database\Eloquent\Relations\Relation;
+use Illuminate\Database\Migrations\Migration;
 use Illuminate\Database\Schema\Blueprint;
 use Illuminate\Support\Facades\File;
 use Orchestra\Testbench\TestCase as Orchestra;
+use Schema;
 use Spatie\MediaLibrary\MediaLibraryServiceProvider;
 use Spatie\MediaLibrary\Support\MediaLibraryPro;
 use Spatie\MediaLibrary\Tests\TestSupport\TestModels\TestModel;
@@ -153,6 +155,21 @@ protected function setUpDatabase($app)
         $mediaTableMigration->up();
     }
 
+    protected function setUpDatabaseCustomKeyName()
+    {
+        $customKeyNameMigration = new class extends Migration
+        {
+            public function up()
+            {
+                Schema::table('media', function (Blueprint $table) {
+                    $table->renameColumn('id', 'custom_key_id');
+                });
+            }
+        };
+
+        $customKeyNameMigration->up();
+    }
+
     protected function setUpTempTestFiles()
     {
         $this->initializeDirectory($this->getTestFilesDirectory());

tests/TestSupport/TestModels/TestCustomMediaWithCustomKeyName.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Spatie\MediaLibrary\Tests\TestSupport\TestModels;
+
+use Spatie\MediaLibrary\MediaCollections\Models\Media;
+
+class TestCustomMediaWithCustomKeyName extends Media
+{
+    protected $table = 'media';
+
+    protected $primaryKey = 'custom_key_id';
+}