improve *-of-type and *-child pseudo selectors #968
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed for preprocessing the node tree
|
Cool. I ran the updated tests with the stock code, and the diffs looked reasonable. @tenderlove What do you think? |
knu
added a commit
that referenced
this pull request
Nov 1, 2013
improve *-of-type and *-child pseudo selectors
|
Thanks! |
|
Retrospectively, this set of commits is awesome. @twalpole , thanks so much for the hard work! Internet high five. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the *-of-type and *-child pseudo selectors when a class name is specified (part of Issue #394) with the element being searched for. Added tests for that scenario and they are all passing. This also removed the need for preprocessing the node tree, thereby simplifying the code