Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS :nth-of-type selector is implemented incorrectly #394

Closed
flavorjones opened this issue Jan 9, 2011 · 4 comments
Closed

CSS :nth-of-type selector is implemented incorrectly #394

flavorjones opened this issue Jan 9, 2011 · 4 comments
Assignees

Comments

@flavorjones
Copy link
Member

see https://gist.github.com/770885 submitted by Wolfram Arnold via nokogiri-talk for reproduction

@flavorjones
Copy link
Member Author

see http://www.mail-archive.com/[email protected]/msg00906.html for one way to correctly implement nth-of-type

that posting also indicates to me that we might want to review the CSS-to-XPath translation for some other selectors.

@szTheory
Copy link

I'd also love to see this feature implemented. When using Capybara (which depends on Nokogiri), it would be very useful for getting at elements in the DOM to test them

@abotalov
Copy link

nth-of-type is very convenient to use in Capybara. It's strange that Nokogiri converts it incorrectly.

@flavorjones
Copy link
Member Author

This was fixed by d5e1ce6 first appearing in v1.6.2. Sorry for not closing earlier.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants