add test case checking decoration of empty NodeSet, which fails on JRuby #1319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What is status? flavorjones/loofah#88 (comment) says this is Rails 4.2 with JRuby. |
|
As I wrote at flavorjones/loofah#94 (comment), I cannot understand loofah and nokogiri support policy. |
|
Looking at this now. |
|
Just an update -- not sure how to fix this without rewriting all of NodeSet. And so the delay in fixing. |
|
@kares This is the second important JRuby issue, which is also blocking Loofah and Rails on JRuby. I've pushed branch |
|
@flavorjones thanks, wondered about this as I stumbled at the doc retrieval code described in the issue |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that empty NodeSets do not have any decorators applied to them on JRuby, while they indeed get decorated on Ruby. The problem seems to be that
initializein XmlNodeSet.java expects the first element of the node set as an argument, where it retrieves the document from which is then used for decoration. empty set -> no first element -> no decoration takes place. I have a test case illustrating the problem, but unfortunately no idea for a solution.Loofah (and therefore also rails-html-sanitizer) has several test cases failing on JRuby because of this.