Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove rbx-2 allow failure from .travis.yml #94

Closed
wants to merge 1 commit into from
Closed

remove rbx-2 allow failure from .travis.yml #94

wants to merge 1 commit into from

Conversation

marutosi
Copy link

@marutosi marutosi commented Nov 9, 2015

No description provided.

@marutosi
Copy link
Author

What is status?

@flavorjones
Copy link
Owner

Hi @marutosi,

Thanks for submitting this PR.

Can you explain a bit about why you want to introduce rbx-2 into the "required" travis builds?

For context, nokogiri (a dependency of loofah) doesn't test against rbx-2 at all, and so until nokogiri supports rbx-2 I'm hesitant to introduce the opportunity for broken builds into the loofah codebase.

@marutosi
Copy link
Author

There is no loofah and nokogiri support policy document.
Broken Jruby Rails 4.2 is serious problem for Redmine.
I am waiting #88 and relating nokogori PRs long time.

@marutosi
Copy link
Author

Broken Jruby Rails 4.2 is serious problem for Redmine.

http://www.redmine.org/projects/redmine/wiki/RedmineInstall#Ruby-interpreter

@flavorjones
Copy link
Owner

I am very sorry, but I do not understand what jruby support has to do with this pull request, which adds a requirement for rubinius-2 support. Can you help me understand?

@marutosi
Copy link
Author

If you keep rbx-2 allow_failures, why do not merge sparklemotion/nokogiri#1319 and sparklemotion/nokogiri#1320 and allow failure nokogiri?
I cannot understand loofah and nokogiri support policy.

@flavorjones
Copy link
Owner

@marutosi I understand that you are frustrated with JRuby support. Thank you for pointing out the related PRs that will address the blockers.

However, I do not understand what this PR has to do with JRuby support, as it deals only with adding rbx-2 as a required build platform. Can you please address my original questions about rbx-2?

@marutosi
Copy link
Author

Can you please address my original questions about rbx-2?

You can see rbx-2 tests passed.
https://travis-ci.org/flavorjones/loofah/builds/80234142

@flavorjones
Copy link
Owner

It sounds like you're asking if I'm prepared to support an additional platform, Rubinius 2.

Based on your feedback above, it's clear that I'm doing a terrible job of supporting the existing platforms, and so I'm going to decline to accept this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants