Skip to content

Commit

Permalink
ci: enforce request review on the final state
Browse files Browse the repository at this point in the history
In apache#5940 (comment),
during solving the merge conflict,
a bug which is fixed in apache#6204 is
reintroduced.
The test is also changed so it can't catch up the regression.

That PR is approved before merging the master. Luckily, I am cautious
enough to start another turn of review.

We should not rely on the lucky or someone else's caution.
To prevent that from happening again, here we enforce the approval
should be applied with the final state.

Signed-off-by: spacewander <[email protected]>
  • Loading branch information
spacewander committed Feb 10, 2022
1 parent 92bbde9 commit 0a0fea7
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions .asf.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ github:
protected_branches:
master:
required_pull_request_reviews:
dismiss_stale_reviews: true
require_code_owner_reviews: true
required_approving_review_count: 2
release/2.12:
Expand Down

0 comments on commit 0a0fea7

Please sign in to comment.