fix(batch-requests): should be disabled by default #6204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Actually it should be disabled in 0aa97c3 Signed-off-by: spacewander <[email protected]>
moonming
approved these changes
Jan 26, 2022
bzp2010
approved these changes
Jan 26, 2022
Signed-off-by: spacewander <[email protected]>
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 26, 2022
Signed-off-by: spacewander <[email protected]>
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Jan 26, 2022
Signed-off-by: spacewander <[email protected]>
spacewander
added a commit
that referenced
this pull request
Jan 26, 2022
Co-authored-by: Zeping Bai <[email protected]>
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Feb 7, 2022
spacewander
added a commit
to spacewander/incubator-apisix
that referenced
this pull request
Feb 10, 2022
In apache#5940 (comment), during solving the merge conflict, a bug which is fixed in apache#6204 is reintroduced. The test is also changed so it can't catch up the regression. That PR is approved before merging the master. Luckily, I am cautious enough to start another turn of review. We should not rely on the lucky or someone else's caution. To prevent that from happening again, here we enforce the approval should be applied with the final state. Signed-off-by: spacewander <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Actually it should be disabled in 0aa97c3
Signed-off-by: spacewander [email protected]
What this PR does / why we need it:
Pre-submission checklist: