-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Specviz JWebbinar notebook #12
Conversation
I also imagine I should probably host the file I'm using on Box, right now it pull straight from SDSS. |
Thank you! |
Added the file to the 2_jdat folder where Duy put their data. I created a link and made it viewable by anyone with the link, but when using this code in the notebook:
I get |
@cslocum that particular error message is something I can fix, but it should only happen if you try to load the same data twice. Can you confirm that that's the case where you saw the error? |
Created a PR in jdaviz to fix that: spacetelescope/jdaviz#568 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After some out-of-band discussion @camipacifici and I realized we want a requirements.txt
so that people who grab this notebook outside of the webbinar know what they need to have installed. So can you add a requirements.txt
a la ac38da0 ?
(It will conflict with the other PRs but there's no helping that, so we'll just have to merge-as-we-go 🤷 )
Looks great! I really like the idea of having beginner and advanced for the exercises. |
I did run it twice. The first time I selected "run all cells", and after the kernel indicated it was idle, I noticed that that particular cell had not been run. So I ran just that one and got the error. I suggest maybe adding a check in there to see if the file already exists? (or at least I think that would fix it/make it more robust.) |
@rosteen
|
Updated, I think the last thing I'm likely to do is write some more detailed notes on the solutions to the exercises. |
I think this is done! Just added detailed solutions to the exercises to the end of the _solutions notebook. |
I tried to be fairly detailed in the notebook, in case people who can't make the live session later get access to the notebook.
Note that this currently uses an SDSS spectrum, as I haven't gotten a nice JWST file to use yet.