Remove unwanted data label input #568
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosteen
requested review from
duytnguyendtn,
ibusko and
javerbukh
as code owners
ibusko
approved these changes
Apr 26, 2021
javerbukh
approved these changes
Apr 28, 2021
There was a problem hiding this comment.
Looks good, however I'm blocked from merging by the same test as the Imviz parser. Do we need @duytnguyendtn to override this as well?
rosteen
force-pushed
the
current-unit-fix
branch
from
df483c8 to
6f92bd7
Compare
|
I just rebased and force pushed, I think that should fix it. |
|
It worked! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shouldn't be passing
data_labeltoget_data_from_viewerhere, because we want whatever data is currently displayed regardless of label.