-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade upload-artifact to v4 #3130
Conversation
The decision to use v3 was intentional, see #2855 But perhaps not needed anymore? 🤷♀️ |
Hard to tell whether this fix works or not given a seemingly unrelated error: I will defer to @rosteen Thank you! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3130 +/- ##
=======================================
Coverage 88.85% 88.85%
=======================================
Files 112 112
Lines 17409 17409
=======================================
Hits 15468 15468
Misses 1941 1941 ☔ View full report in Codecov by Sentry. |
You are right! The underlying issue of "too many open files" described in the pull request you quote was addressed in the issue actions/upload-artifact#485 which just recently got fixed in the following pull request actions/toolkit#1771 2 weeks ago. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only one way to find out. Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since the fix was released, seems like we can go back to v4. Thanks!
Description
This pull request upgrades the upload-artifact action to v4 following the closing of actions/upload-artifact#485 by release 4.3.5 which allows the v4 action to handle a large amount of files in the artifact zip file.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.