upgrade upload-artifact to v4

[Migelo]

Description

This pull request upgrades the upload-artifact action to v4 following the closing of actions/upload-artifact#485 by release 4.3.5 which allows the v4 action to handle a large amount of files in the artifact zip file.

Change log entry

• Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
  list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
  should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

• Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
• Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
• Do the proposed changes follow the STScI Style Guides?
• Are tests added/updated as required? If so, do they follow the STScI Style Guides?
• Are docs added/updated as required? If so, do they follow the STScI Style Guides?
• Did the CI pass? If not, are the failures related?
• Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
• After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

[pllim]

The decision to use v3 was intentional, see #2855

But perhaps not needed anymore? 🤷‍♀️

[pllim]

Hard to tell whether this fix works or not given a seemingly unrelated error: Error: Timed out waiting for: tcp:8866

I will defer to @rosteen

Thank you!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.85%. Comparing base (b3bbd9f) to head (01f8880).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3130   +/-   ##
=======================================
  Coverage   88.85%   88.85%           
=======================================
  Files         112      112           
  Lines       17409    17409           
=======================================
  Hits        15468    15468           
  Misses       1941     1941           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Migelo]

The decision to use v3 was intentional, see #2855

You are right! The underlying issue of "too many open files" described in the pull request you quote was addressed in the issue actions/upload-artifact#485 which just recently got fixed in the following pull request actions/toolkit#1771 2 weeks ago.

[pllim]

Only one way to find out. Thanks!

[rosteen]

Since the fix was released, seems like we can go back to v4. Thanks!