Prevent "too many open files" in artifact upload #1771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 23, 2024
robherley
approved these changes
Jul 23, 2024
|
Once #1774 is merged, I'll rebase on top of the new state of |
rmunn
force-pushed
the
fix-too-many-open-files
branch
from
65faef4
to
9517cdf
Compare
|
Just rebased on top of |
|
@robherley - Looks like a team member needs to re-approve running the workflows again. |
|
Looks like this can be removed: import {createReadStream} from 'fs' |
Done in commit 7c61054. |
|
@robherley - Your approving review is now considered stale because I rebased and pushed one new commit. Want to give this another look? I should be done making changes. |
robherley
approved these changes
Jul 31, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes actions/upload-artifact#485.
The
.filemethod uses "a lazystream wrapper to prevent issues with open file limits", which is precisely the scenario we're running into with actions/upload-artifact#485.This was originally part of #1723, but I pulled the bugfix out into its own PR so it can be reviewed separately from the bugfix that #1723 was for (preserving Unix file permissions in uploaded .zip files). This one is more urgent than the Unix file permissions, which can be worked around by uploading a .tar file.