Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR 2802 to v3.9.x (BUG: Fix random flip in WCS orientation) #2804

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

pllim
Copy link
Contributor

@pllim pllim commented Apr 16, 2024

Description

This pull request is to manually backport #2802 because auto backport failed because #2789 was not backported.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone. Bugfix milestone also needs an accompanying backport label.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

* BUG: Fix random flip in WCS orientation

* TST: Update test results

(cherry picked from commit 620ccfe)
@pllim pllim added trivial Only needs one approval instead of two skip-changelog-checks changelog bot directive labels Apr 16, 2024
@pllim pllim added this to the 3.9.1 milestone Apr 16, 2024
@github-actions github-actions bot added the imviz label Apr 16, 2024
@pllim
Copy link
Contributor Author

pllim commented Apr 16, 2024

Failure is same as #2805 🤷‍♀️

@pllim pllim merged commit 37570c8 into spacetelescope:v3.9.x Apr 16, 2024
9 of 14 checks passed
@pllim pllim deleted the backport-pr2802-to-v3.9.x branch April 16, 2024 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
imviz skip-changelog-checks changelog bot directive trivial Only needs one approval instead of two
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants