Fix Orientation selection/creation with no loaded data #2789
Conversation
rosteen
requested review from
javerbukh,
pllim,
kecnry,
bmorris3,
haticekaratay,
cshanahan1 and
gibsongreen
as code owners
github-actions
bot
added
the
plugin
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2789 +/- ##
==========================================
+ Coverage 88.72% 88.77% +0.04%
==========================================
Files 110 110
Lines 16353 16547 +194
==========================================
+ Hits 14509 14689 +180
- Misses 1844 1858 +14 ☔ View full report in Codecov by Sentry. |
|
I'll add test coverage later today. |
| set_on_create=True, wrt_data=None): | ||
| set_on_create=True, wrt_data=None, from_ui=False): |
There was a problem hiding this comment.
Since this is a publicly exposed method, is there any user-friendly name we can use here? Maybe just require_data? Or can we instead wrap with a try/except at the vue_* level that converts errors into snackbars and leaves the public methods alone?
There was a problem hiding this comment.
Hmm. I could also make add_orientation just pass the public-facing args to a private _add_orientation that has the new keyword for use by the vue_ method. I'll think about the best way to do this.
There was a problem hiding this comment.
I moved the new keyword arg to a private method.
| @@ -332,6 +341,12 @@ def add_orientation(self, rotation_angle=None, east_left=None, label=None, | |||
| # default rotation: | |||
| wrt_data = self.viewer.selected_obj.first_loaded_data | |||
| if wrt_data is None: # Nothing in viewer | |||
| msg = "Viewer must have data loaded to add an orientation." | |||
| if from_ui: | |||
There was a problem hiding this comment.
Personally, I prefer more explicit name like raise_exception=False. From UI is just one of many possible reason why someone might want or not want an exception raised. But I'll leave it up to you.
There was a problem hiding this comment.
I'm not too worried about the semantics since this isn't exposed in the public API, it's only in the private method that we use internally now. I think I'll leave it as-is until a more general reason to raise an error here comes up. Thanks for the thought.
|
This does not have a backport but milestoned to 3.9.1. Please backport or update the milestone. Thanks! |
…e#2789) * Raise error or snackbar if adding an orientation with no data loaded * Don't update with infinite bounds * Codestyle * Add changelog * Adding tests * Load data after orientation switch * Codestyle * Move new keyword to private method * Fix indents
|
Manual backport at #2808. |
This improves the orientation code to catch the error and raise a snackbar warning if an orientation is added before loading data into the viewer, and stops the backend from trying to set bounds to
infif an orientation is selected in the data menu before data is loaded.