unpin tox < 4 #1906
Merged
unpin tox < 4 #1906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f36f3b2.
kecnry
added
trivial
Codecov ReportBase: 88.48% // Head: 88.48% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1906 +/- ##
=======================================
Coverage 88.48% 88.48%
=======================================
Files 95 95
Lines 10540 10540
=======================================
Hits 9326 9326
Misses 1214 1214 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Interesting... I thought I would have to wait longer based on all the stuff astropy is seeing. |
pllim
approved these changes
Dec 8, 2022
kecnry
requested review from
duytnguyendtn,
rosteen,
javerbukh,
ojustino and
bmorris3
as code owners
meeseeksmachine
pushed a commit
to meeseeksmachine/jdaviz
that referenced
this pull request
Dec 8, 2022
pllim
added a commit
that referenced
this pull request
Dec 8, 2022
…6-on-v3.1.x Backport PR #1906 on branch v3.1.x (unpin tox < 4)
|
So speedy! 🚀 |
|
You might want to be careful here, we have been experiencing similar issues an v4.0.11 worked for us, but not the latest 4.1.3 of tox. So issue might start to occur again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit f36f3b2.
Description
This pull request reverts #1901
Fixes #1903