Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

numpy deprecation warning filter for v1.24.0 #1873

Merged
merged 13 commits into from
Nov 29, 2022
Merged

numpy deprecation warning filter for v1.24.0 #1873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
0961ae2
numpy deprecation warning filter for v1.24.0
bmorris3 Nov 28, 2022
e9be141
Fixing np.float_ type casting
bmorris3 Nov 28, 2022
d098d2b
more specific warning for pytest
bmorris3 Nov 28, 2022
7b0382c
dodging regex failure
bmorris3 Nov 28, 2022
b53ac6b
Update setup.cfg
bmorris3 Nov 28, 2022
ce92cfa
fixing another deprecation warning
bmorris3 Nov 28, 2022
dbbc5d0
fixing another deprecation warning
bmorris3 Nov 28, 2022
3a36d62
Adding np.int0 to filtered warnings
bmorris3 Nov 29, 2022
a9427bf
Use built-in float
pllim Nov 29, 2022
ac7330c
Make slice test more deterministic
pllim Nov 29, 2022
0b173c9
See if I broke it
pllim Nov 29, 2022
f6d0f8b
Oooops
pllim Nov 29, 2022
c12b10a
Back to built-in float
pllim Nov 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions jdaviz/configs/cubeviz/plugins/slice/tests/test_slice.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,9 @@ def test_slice(cubeviz_helper, spectrum1d_cube):

# Test player buttons API

sl.vue_goto_first()
assert sl.slice == 0

sl.vue_goto_last()
assert sl.slice == sl.max_value

Expand All @@ -89,9 +92,6 @@ def test_slice(cubeviz_helper, spectrum1d_cube):
assert not sl._player
# NOTE: Hard to check sl.slice here because it is non-deterministic.

sl.vue_goto_first()
assert sl.slice == 0


def test_indicator_settings(cubeviz_helper, spectrum1d_cube):
app = cubeviz_helper.app
Expand Down
4 changes: 2 additions & 2 deletions jdaviz/configs/mosviz/plugins/slit_overlay/slit_overlay.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,8 @@
def jwst_header_to_skyregion(header):
s_region = header['S_REGION']
footprint = s_region.split("POLYGON ICRS")[1].split()
ra = np.array(footprint[::2], dtype=np.float)
dec = np.array(footprint[1::2], dtype=np.float)
ra = np.array(footprint[::2], dtype=float)
dec = np.array(footprint[1::2], dtype=float)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I backported this to v3.1.x in d7ec0ab


# Find center of slit
cra = (max(ra) + min(ra)) / 2
Expand Down
3 changes: 3 additions & 0 deletions setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,6 +97,9 @@ filterwarnings =
ignore:distutils Version classes are deprecated:DeprecationWarning
ignore:Passing unrecognized arguments to super:DeprecationWarning
ignore:.*With traitlets 4\.1, metadata should be set using the \.tag\(\) method:DeprecationWarning
ignore:.*np\.bool8.*is a deprecated alias for:DeprecationWarning
ignore:.*np\.uint0.*is a deprecated alias for:DeprecationWarning
ignore:.*np\.int0.*is a deprecated alias for:DeprecationWarning
ignore::DeprecationWarning:glue
ignore::DeprecationWarning:bqplot
ignore::DeprecationWarning:bqplot_image_gl
Expand Down