-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
numpy deprecation warning filter for v1.24.0 #1873
numpy deprecation warning filter for v1.24.0 #1873
Conversation
Codecov ReportBase: 88.37% // Head: 88.37% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1873 +/- ##
=======================================
Coverage 88.37% 88.37%
=======================================
Files 95 95
Lines 10456 10456
=======================================
Hits 9241 9241
Misses 1215 1215
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Blanket ignore seems overkill for something that only crops up on dev job.
Lemme catch up on the logs and see if we can do something more localized.
@pllim – to help you up to speed, see this warning, for example. Would you be more comfortable with a more specific ignore for |
Argh, so it is from |
You might need to fix the regex. |
@pllim That's what I was worried about, but couldn't figure out how to test it locally. Trying again. |
Co-authored-by: P. L. Lim <[email protected]>
Maybe it was
|
Also these are strictly upstream right? Do you plan to fix |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When CI pass, I will squash and merge.
Note to self: Open follow up issue to undo this.
This comment was marked as resolved.
This comment was marked as resolved.
Remaining failures in the devdeps job all use https://stsci.box.com/shared/static/exnkul627fcuhy5akf2gswytud5tazmw.fits . Curious that this file worked with the other remote data job but not this one, but investigating it is out of scope here. Update: Maybe this file is too old and not compatible with latest asdf stuff. Should replace it with real data from orbit. |
Co-authored-by: Brett M. Morris <[email protected]>
ra = np.array(footprint[::2], dtype=np.float) | ||
dec = np.array(footprint[1::2], dtype=np.float) | ||
ra = np.array(footprint[::2], dtype=float) | ||
dec = np.array(footprint[1::2], dtype=float) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I backported this to v3.1.x in d7ec0ab
Numpy v1.24.0 triggers several deprecation warnings in scikit-image. See progress on fixes in scikit-image/scikit-image#6633, and failure in #1834.
This PR tries to filter out that specific deprecation warning.
Description
This pull request is to address ...
Fixes #
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.