Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport PR #1812 on branch v3.1.x (FIX: mosviz image remove on row change) #1814

Conversation

meeseeksmachine
Copy link

Backport PR #1812: FIX: mosviz image remove on row change

@lumberbot-app lumberbot-app bot added this to the 3.1.1 milestone Nov 2, 2022
@lumberbot-app lumberbot-app bot added 💤backport-v3.1.x on-merge: backport to v3.1.x bug Something isn't working mosviz trivial Only needs one approval instead of two labels Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 87.81% // Head: 87.81% // No change to project coverage 👍

Coverage data is based on head (22349cd) compared to base (c39c2a0).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           v3.1.x    #1814   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files          95       95           
  Lines       10179    10179           
=======================================
  Hits         8939     8939           
  Misses       1240     1240           
Impacted Files Coverage Δ
jdaviz/core/helpers.py 69.61% <ø> (ø)
jdaviz/configs/mosviz/plugins/viewers.py 79.41% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim
Copy link
Contributor

pllim commented Nov 2, 2022

No need to wait for devdeps.

@pllim pllim merged commit 9941c7e into spacetelescope:v3.1.x Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mosviz trivial Only needs one approval instead of two 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants