-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX: mosviz image remove on row change #1812
Conversation
b44d374
to
8a1eb25
Compare
Codecov ReportBase: 88.06% // Head: 88.06% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #1812 +/- ##
=======================================
Coverage 88.06% 88.06%
=======================================
Files 95 95
Lines 10204 10204
=======================================
Hits 8986 8986
Misses 1218 1218
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, sorry I didn't catch this myself!
timeout on remote data is unrelated |
…2-on-v3.1.x Backport PR #1812 on branch v3.1.x (FIX: mosviz image remove on row change)
Description
This pull request fixes a small bug introduced in #1681 where the image from the previous row (in mosviz) was not removed from the image viewer when changing rows in the table.
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.