Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: mosviz image remove on row change #1812

Merged
merged 1 commit into from
Nov 2, 2022

Conversation

kecnry
Copy link
Member

@kecnry kecnry commented Nov 2, 2022

Description

This pull request fixes a small bug introduced in #1681 where the image from the previous row (in mosviz) was not removed from the image viewer when changing rows in the table.

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set? Set this to bugfix milestone if this is a bug fix and needs to be released ASAP; otherwise, set this to the next major release milestone.
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@kecnry kecnry added bug Something isn't working mosviz labels Nov 2, 2022
@kecnry kecnry added this to the 3.1.1 milestone Nov 2, 2022
@kecnry kecnry force-pushed the fix-mosviz-image-row-change branch from b44d374 to 8a1eb25 Compare November 2, 2022 16:17
@kecnry kecnry added the trivial Only needs one approval instead of two label Nov 2, 2022
@kecnry kecnry marked this pull request as ready for review November 2, 2022 16:19
@kecnry kecnry added the 💤backport-v3.1.x on-merge: backport to v3.1.x label Nov 2, 2022
@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Base: 88.06% // Head: 88.06% // No change to project coverage 👍

Coverage data is based on head (8a1eb25) compared to base (914c940).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1812   +/-   ##
=======================================
  Coverage   88.06%   88.06%           
=======================================
  Files          95       95           
  Lines       10204    10204           
=======================================
  Hits         8986     8986           
  Misses       1218     1218           
Impacted Files Coverage Δ
jdaviz/configs/mosviz/plugins/viewers.py 85.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@bmorris3 bmorris3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, sorry I didn't catch this myself!

@kecnry
Copy link
Member Author

kecnry commented Nov 2, 2022

timeout on remote data is unrelated

@kecnry kecnry merged commit d136397 into spacetelescope:main Nov 2, 2022
@kecnry kecnry deleted the fix-mosviz-image-row-change branch November 2, 2022 17:01
meeseeksmachine pushed a commit to meeseeksmachine/jdaviz that referenced this pull request Nov 2, 2022
pllim added a commit that referenced this pull request Nov 2, 2022
…2-on-v3.1.x

Backport PR #1812 on branch v3.1.x (FIX: mosviz image remove on row change)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working mosviz trivial Only needs one approval instead of two 💤backport-v3.1.x on-merge: backport to v3.1.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants