Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for blank tabbed viewers after selection #1718

Merged
merged 1 commit into from
Oct 14, 2022
Merged

fix: workaround for blank tabbed viewers after selection #1718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGES.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,8 @@ Bug Fixes

- Fix subset selection tool conflicts caused by a duplicate toolbar. [#1679]

- Fixed blank tabbed viewers. [#1718]

Cubeviz
^^^^^^^

Expand Down
5 changes: 5 additions & 0 deletions jdaviz/app.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,7 @@
<golden-layout
style="height: 100%;"
:has-headers="state.settings.visible.tab_headers"
@state="onLayoutChange"
>
<gl-row :closable="false">
<g-viewer-tab
Expand Down Expand Up @@ -178,6 +179,10 @@ export default {
}
// simple exact text search match on the plugin title for now.
return trayItem.label.toLowerCase().indexOf(tray_items_filter.toLowerCase()) !== -1
},
onLayoutChange() {
/* Workaround for #1677, can be removed when bqplot/bqplot#1531 is released */
window.dispatchEvent(new Event('resize'));
}
},
created() {
Expand Down