-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: workaround for blank tabbed viewers after selection #1718
Conversation
6605a22
to
5b10db4
Compare
Codecov ReportBase: 87.27% // Head: 87.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #1718 +/- ##
=======================================
Coverage 87.27% 87.28%
=======================================
Files 95 95
Lines 10084 10127 +43
=======================================
+ Hits 8801 8839 +38
- Misses 1283 1288 +5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
We're still trying to figure out the change log check situation w.r.t. branched release model here, hence the current check failure. Otherwise, this patch seems to fix the Cubeviz viewer issue. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed the behavior on my end! Thanks @mariobuikhuizen!
Though I will say it still flashes blank for me before it resizes properly. Before we forget, @mariobuikhuizen do you know why this happens at all? (that being, turns entirely blank)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works on my end, thanks! Just needs to be rebased and the change log entry moved to the 3.0.2 section (or I can do that and force push to your branch if you'd like?).
5b10db4
to
3dcfe34
Compare
@duytnguyendtn I don't know why it turns blank. I will take a short look if I can find that out. |
…d_viewer fix: workaround for blank tabbed viewers after selection (cherry picked from commit fec3a1b)
Description
Fixes #1677
After merging this
Change log entry
CHANGES.rst
? If you want to avoid merge conflicts,list the proposed change log here for review and add to
CHANGES.rst
before merge. If no, maintainershould add a
no-changelog-entry-needed
label.Checklist for package maintainer(s)
This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.
trivial
label.