Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for blank tabbed viewers after selection #1718

Merged
merged 1 commit into from
Oct 14, 2022

Conversation

mariobuikhuizen
Copy link
Collaborator

@mariobuikhuizen mariobuikhuizen commented Oct 11, 2022

Description

Fixes #1677

After merging this

Change log entry

  • Is a change log needed? If yes, is it added to CHANGES.rst? If you want to avoid merge conflicts,
    list the proposed change log here for review and add to CHANGES.rst before merge. If no, maintainer
    should add a no-changelog-entry-needed label.

Checklist for package maintainer(s)

This checklist is meant to remind the package maintainer(s) who will review this pull request of some common things to look for. This list is not exhaustive.

  • Are two approvals required? Branch protection rule does not check for the second approval. If a second approval is not necessary, please apply the trivial label.
  • Do the proposed changes actually accomplish desired goals? Also manually run the affected example notebooks, if necessary.
  • Do the proposed changes follow the STScI Style Guides?
  • Are tests added/updated as required? If so, do they follow the STScI Style Guides?
  • Are docs added/updated as required? If so, do they follow the STScI Style Guides?
  • Did the CI pass? If not, are the failures related?
  • Is a milestone set?
  • After merge, any internal documentations need updating (e.g., JIRA, Innerspace)?

@github-actions github-actions bot added the embed Regarding issues with front-end embedding label Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 87.27% // Head: 87.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (3dcfe34) compared to base (5c8cea2).
Patch coverage: 90.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1718   +/-   ##
=======================================
  Coverage   87.27%   87.28%           
=======================================
  Files          95       95           
  Lines       10084    10127   +43     
=======================================
+ Hits         8801     8839   +38     
- Misses       1283     1288    +5     
Impacted Files Coverage Δ
...z/configs/default/plugins/data_tools/data_tools.py 64.51% <ø> (+3.91%) ⬆️
...plugins/spectral_extraction/spectral_extraction.py 90.57% <ø> (ø)
jdaviz/configs/imviz/plugins/catalogs/catalogs.py 91.22% <90.00%> (-4.43%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@pllim pllim modified the milestones: 3.1, 3.0.2 Oct 11, 2022
@pllim pllim added the bug Something isn't working label Oct 11, 2022
@pllim
Copy link
Contributor

pllim commented Oct 11, 2022

We're still trying to figure out the change log check situation w.r.t. branched release model here, hence the current check failure.

Otherwise, this patch seems to fix the Cubeviz viewer issue. Thanks!

Copy link
Collaborator

@duytnguyendtn duytnguyendtn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed the behavior on my end! Thanks @mariobuikhuizen!

Though I will say it still flashes blank for me before it resizes properly. Before we forget, @mariobuikhuizen do you know why this happens at all? (that being, turns entirely blank)

Copy link
Member

@kecnry kecnry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works on my end, thanks! Just needs to be rebased and the change log entry moved to the 3.0.2 section (or I can do that and force push to your branch if you'd like?).

@kecnry kecnry merged commit fec3a1b into spacetelescope:main Oct 14, 2022
@mariobuikhuizen
Copy link
Collaborator Author

@duytnguyendtn I don't know why it turns blank. I will take a short look if I can find that out.

rosteen pushed a commit to rosteen/jdaviz that referenced this pull request Oct 18, 2022
…d_viewer

fix: workaround for blank tabbed viewers after selection
(cherry picked from commit fec3a1b)
@pllim pllim mentioned this pull request Oct 26, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working embed Regarding issues with front-end embedding
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Cubeviz: Tabbed viewer is blank on initial selection
4 participants