-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astrowidgets API using SkyCoord confusing when coord is out of bounds in dithered images #1509
Comments
This issue is tracked on JIRA as JDAT-2613. |
Comment by Duy Nguyen on JIRA: NOTICE: A corresponding GitHub issue was automatically created: #1509 |
Comment by Camilla Pacifici on JIRA: Was about to create a new ticket, then I found this. My issue is probably related: For the reference image, only pixels are reported. If you already have the CEERS images on your machine, you can use: |
Comment by Pey-Lian Lim on JIRA: Camilla Pacifici , what is the desired behavior? See bottom of original post. Thanks! |
Comment by Camilla Pacifici on JIRA: Sorry, desired behavior is to see the coordinates (both pixels and physical) everywhere, not just in a small part of the viewer. Is this feasible? I do not understand what would go into the mentioned API changes. |
Comment by Pey-Lian Lim on JIRA: The main problem is GWCS does not allow extrapolation. So if markers are linked against reference image and that image has GWCS, any markers outside of the GWCS field-of-view will return NaN pixels. This is GWCS behavior outside our control. If you want "everywhere," we basically have to create a mosaic WCS and use that but that would involve some third-party software to do. Or ask GWCS to support extrapolation. |
Comment by Camilla Pacifici on JIRA: Would it be an option to use the approximated WCS instead of GWCS? |
Comment by Pey-Lian Lim on JIRA: For JWST, FITS WCS is not to be relied on if there is distortion. Not being an expert in all the possible pipeline products, I wouldn't know when it is safe to use. If you have rules on when to give this option and how user wants to use this option, please let us know. Thanks! |
Comment by Camilla Pacifici on JIRA: Gotcha. i2d files would be corrected for distortion, so maybe for those the approximated WCS could be used.
|
Comment by Pey-Lian Lim on JIRA: Just ignoring GWCS and load FITS WCS no matter what would be easiest but then you still have the same problem with Roman data that is pure ASDF (no FITS WCS at all). I don't think any approximation would do for Roman stuff. |
Comment by Richard O'Steen on JIRA: This is the same underlying problem as JDAT-2980 |
Reporter: pllim
This is best demonstrated by the MIRI and NIRCam galaxy/supernova images that @orifox still needs to provide. MIRI has much larger FOV but smaller in pixel dimension. NIRCam has small FOV but large pixel dimension. When linked by WCS, they overlap partially with NIRCam off to the lower right corner of the MIRI FOV. The sky coordinate of interest belongs to a known supernova that is in NIRCam image but outside of MIRI. And we are also talking about GWCS here, that purposely does not extrapolate beyond image boundary (it was a conscious design choice by GWCS).
Workflow to reproduce:
imviz.default_viewer.center_on(my_skycoord)
Desired outcome can be either:
🐱
DISCLAIMER: This issue was autocreated by the Jdaviz Issue Creation Bot on behalf of the reporter. If any information is incorrect, please contact Duy Nguyen
The text was updated successfully, but these errors were encountered: