feat: add sort_merge_join
#397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iajoiner
force-pushed
the
feat/inner-join
branch
6 times, most recently
from
f40b136 to
311c8e8
Compare
iajoiner
force-pushed
the
feat/inner-join
branch
4 times, most recently
from
c4d35e6 to
f89e6c6
Compare
JayWhite2357
requested changes
Dec 16, 2024
iajoiner
force-pushed
the
feat/inner-join
branch
5 times, most recently
from
cab2edf to
24c8c44
Compare
iajoiner
force-pushed
the
feat/inner-join
branch
2 times, most recently
from
279698a to
6c79e26
Compare
iajoiner
force-pushed
the
feat/inner-join
branch
from
6c79e26 to
a90e584
Compare
iajoiner
force-pushed
the
feat/inner-join
branch
from
a2a3fce to
9a535e1
Compare
JayWhite2357
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version 0.64.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please be sure to look over the pull request guidelines here: https://github.com/spaceandtimelabs/sxt-proof-of-sql/blob/main/CONTRIBUTING.md#submit-pr.
Please go through the following checklist
!is used if and only if at least one breaking change has been introduced.source scripts/run_ci_checks.sh.compare_single_row_of_tables#391column_index_operation#396proof_of_sql_parser::intermediate_ast::Identifierwithsqlparser::ast::Identin the proof-of-sql crate #382Rationale for this change
This PR adds the actual sort-merge join process which completes a part of #394.
What changes are included in this PR?
sort_merge_join.Are these changes tested?
Yes.