refactor: address review comment

spaceandtimelabs · Dec 18, 2024 · a2a3fce · a2a3fce
1 parent a90e584
commit a2a3fce
Showing 1 changed file with 2 additions and 5 deletions.
diff --git a/crates/proof-of-sql/src/base/database/join_util.rs b/crates/proof-of-sql/src/base/database/join_util.rs
@@ -11,7 +11,7 @@ use crate::base::{
 use alloc::vec::Vec;
 use bumpalo::Bump;
 use core::cmp::Ordering;
-use itertools::Itertools;
+use itertools::{iproduct, Itertools};
 use sqlparser::ast::Ident;
 
 /// Compute the CROSS JOIN / cartesian product of two tables.
@@ -103,10 +103,7 @@ fn get_sort_merge_join_indexes<'a, S: Scalar>(
                     .collect();
 
                 // Generate all pairs (Cartesian product)
-                let pairs: Vec<_> = left_group
-                    .iter()
-                    .flat_map(|&l| right_group.iter().map(move |&r| (l, r)))
-                    .collect();
+                let pairs: Vec<_> = iproduct!(left_group, right_group).collect();
 
                 // Advance the iterators
                 left_iter.nth(left_group.len() - 1);